Reindex resource when link status changes - #1147
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to automatically reindex search resources when their link status changes between working and broken states. This ensures that resources with dead links are properly excluded from search results and resources that come back online are re-included.
- Adds a
status_changed?method to detect transitions between working and failing link states - Implements automatic reindexing via an
after_commitcallback when link status changes - Includes comprehensive test coverage for the status change detection logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/models/link_monitor.rb | Adds status change detection and automatic reindexing callback |
| test/models/link_monitor_test.rb | Adds test coverage for the new status change detection method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
Resources with dead links were showing up in search results due to not being indexed after the link monitor updated.
Checklist
to license it to the TeSS codebase under the
BSD license.